Support listener attributes #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
wweiwei-li
force-pushed
the
listenerAttributes
branch
2 times, most recently
from
a8a4a41 to
cbe94e0
Compare
shraddhabang
approved these changes
Sep 24, 2024
pkg/deploy/elbv2/listener_manager.go
Outdated
| @@ -354,3 +366,16 @@ func buildResListenerStatus(sdkLS ListenerWithTags) elbv2model.ListenerStatus { | |||
| ListenerARN: awssdk.ToString(sdkLS.Listener.ListenerArn), | |||
| } | |||
| } | |||
|
|
|||
| var PROTOCOLS_WITH_ATTRIBUTES = map[elbv2model.Protocol]bool{ | |||
There was a problem hiding this comment.
Nit:
- Define these constants at the beginning
- Change from
vartoconst - Change constant name to reflect listener attributes
PROTOCOLS_SUPPORTING_LISTENER_ATTRIBUTES
There was a problem hiding this comment.
Resolved 1 and 3.
- Defined it at the beginning
- Changed constant name to reflect listener attributes PROTOCOLS_SUPPORTING_LISTENER_ATTRIBUTES.
However, for 2. I can't set it as const because maps cannot be declared as constants in Go.
wweiwei-li
force-pushed
the
listenerAttributes
branch
from
cbe94e0 to
12a33e6
Compare
wweiwei-li
force-pushed
the
listenerAttributes
branch
from
12a33e6 to
174ad83
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, shraddhabang, wweiwei-li The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3843
Description
Add listener attributes support by
service.beta.kubernetes.io/aws-load-balancer-listener-attributes.${Protocol}-{Port}annotation, which allows dynamically configuration of protocol and port. With the combination of protocol and port, it serves as a unique identifier, enabling us to identify the listener and set attributes to it accordingly. For example, setservice.beta.kubernetes.io/aws-load-balancer-listener-attributes.TCP-80: tcp.idle_timeout.seconds=700Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯